Document unittest_args in run_tests.py --help #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
approved these changes
Sep 17, 2024
Collaborator
bstaletic
left a comment
bstaletic
left a comment
There was a problem hiding this comment.
Thanks for the pull request.
I think we should just drop --no-clang-completer, --no-completers and --completers. Those arguments have been a no-op for who knows how long.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)
dkaszews
commented
Sep 18, 2024
Contributor
Author
dkaszews
left a comment
dkaszews
left a comment
There was a problem hiding this comment.
Are you sure? They are used by the BuildYcmdLibs, though it is a bit misleading as it would make more sense if they selected tests, not build components:
> .\run_tests.py
Running tests on Python 3.12.4
Running flake8
DKASZEWS: subprocess.check_call( ['C:\\Program Files\\Python312\\python.exe', 'C:\\Users\\dkaszews\\AppData\\Local\\nvim-data\\plugged\\YouCompleteMe\\third_party\\ycmd\\build.py', '--core-tests', '--clang-completer', '--cs-completer', '--js-completer', '--ts-completer', '--java-completer', '--clangd-completer', '--rust-completer', '--go-completer', '--msvc', '16'] )
> .\run_tests.py --completers cs
Running tests on Python 3.12.4
Running flake8
DKASZEWS: subprocess.check_call( ['C:\\Program Files\\Python312\\python.exe', 'C:\\Users\\dkaszews\\AppData\\Local\\nvim-data\\plugged\\YouCompleteMe\\third_party\\ycmd\\build.py', '--core-tests', '--cs-completer', '--msvc', '16
'] )Reviewable status: 0 of 2 LGTMs obtained (waiting on @dkaszews)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a line of help after usage to document
run_tests.pypassing unknown arguments tounittest.> ./run_tests.py --help usage: run_tests.py [-h] [--no-completers [{cfamily,cs,javascript,typescript,python,java,clangd,rust,go} ...] | --completers [{cfamily,cs,javascript,typescript,python,java,clangd,rust,go} ...]] [--skip-build] [--msvc {15,16,17}] [--coverage] [--no-flake8] [--dump-path] [--no-retry] [--quiet] [--valgrind] +Unknown arguments are passed to unittest module, e.g. to select test cases. See `python -m unittest --help` for more details. options:This change is